Add context for GraphQL and REST clients #50
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
context.Context
for GraphQL client. For all methods there is alternative, with pattern{method_name}WithContext
context.Canceled
andcontext.DeadlineExceeded
to prevent any regression.context.Context
for REST client. I added onlyDoWithContext
andRequestWithContext
. Rest methods are just a syntax sugar, and I don't see value into adding an alternative method to all of them. However, it's easy to add, so if you want to, let me know and I will do it 馃憤context.Canceled
andcontext.DeadlineExceeded
to prevent any regression.Related issue(s)
Fixes #47